Prevent our own gsm.h from being shadowed
#310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`libgsm` is typically installed with a top-level `gsm.h` include file (either as the main file or as a compatibility symlink to `gsm/gsm.h`). If `libgsm` is installed but `WITH_GSM` is disabled, it's possible that this copy will shadow our own when `audio/gsm/src` is being built, depending on how include directories are ordered. This will typically cause a build failure on systems such as FreeBSD, where `/usr/local/include` is inserted early in the list, such as seen in LubosD#305 (comment). (While both copies are almost identical, the original one enforces C linkage, which ours does not.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgsmis typically installed with a top-levelgsm.hinclude file (either as the main file or as a compatibility symlink togsm/gsm.h). Iflibgsmis installed butWITH_GSMis disabled, it's possible that this copy will shadow our own whenaudio/gsm/srcis being built, depending on how include directories are ordered.This will typically cause a build failure on systems such as FreeBSD, where
/usr/local/includeis inserted early in the list, such as seen in #305 (comment).(While both copies are almost identical, the original one enforces C linkage, which ours does not.)